fix: support tracing awaited mongoose queries #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9abe524 to
103d856
Compare
DominicKramer
approved these changes
Apr 29, 2019
|
TBR=@ofrobots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1000
The problem occurs because
Query#exec(which makes the MongoDB API call) occurs within the body of a userspacethencall, which has no context whenawaited. To remedy this, we patch newQueryobjects so thatexechas the same context as where theQuerywas created. This assumes that we want context at the API call to be the same as the place whereQuerywas constructed. As much (if not all) of the Mongoose read APIs create and execute theQueryobjects in a single function call, I believe this to be a safe assumption.