Skip to content

Commit

Permalink
test: fixup issue stemming from testing http2 on node 9.9 (#699)
Browse files Browse the repository at this point in the history
PR-URL: #699
  • Loading branch information
kjin authored Mar 23, 2018
1 parent 770ab08 commit dca5cc0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/plugins/test-trace-http2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ describe('test-trace-http2', () => {
server.on(
'stream',
(s: http2.ServerHttp2Stream&({rstWithInternalError: () => void})) => {
// In Node 9.9+, the error handler is not added by default.
s.on('error', () => {});
setTimeout(() => {
if (semver.satisfies(process.version, '>=9.4')) {
// Node 9.4 removed rstWithInternalError() and uses added close().
Expand Down

0 comments on commit dca5cc0

Please sign in to comment.