fix: drop warning message for non-patched modules

googleapis · Mar 20, 2018 · 6f73473 · 6f73473
1 parent fa33f25
commit 6f73473
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/trace-plugin-loader.ts b/src/trace-plugin-loader.ts
@@ -192,9 +192,6 @@ export class ModulePluginWrapper implements PluginWrapper {
       } else if (instrumentation.intercept) {
         exportedValue = instrumentation.intercept(
             exportedValue, this.createTraceAgentInstance(file));
-      } else {
-        this.logger.warn(`PluginWrapper#applyPlugin: [${
-            logString}] Patch object has no known functions for patching this file.`);
       }
       return exportedValue;
     }, moduleExports as T);

diff --git a/test/test-plugin-loader.ts b/test/test-plugin-loader.ts
@@ -324,13 +324,14 @@ describe('Trace Plugin Loader', () => {
 
     it('warns when a module is patched by a non-conformant plugin', () => {
       makePluginLoader({plugins: {'[core]': 'plugin-core'}}).activate();
-      // Reasons for warnings issued are listed as comments.
+      // Reasons for possible warnings issued are listed as comments.
       require('crypto');  // neither patch nor intercept
       require('os');      // both patch and intercept
       require('dns');     // two Patch objects for a single file
+      // Do not warn when there is no patch/intercept function.
       assert.strictEqual(
           logger.getNumLogsWith('warn', `[[core]@${PROCESS_VERSION}:crypto]`),
-          1);
+          0);
       assert.strictEqual(
           logger.getNumLogsWith('warn', `[[core]@${PROCESS_VERSION}:os]`), 1);
       assert.strictEqual(