Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update another conformance test to determine if request is full table scan #218

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

danieljbruce
Copy link
Collaborator

@danieljbruce danieljbruce commented Dec 12, 2024

Summary

The NodeJS CBT client fails the TestReadRows_Retry_StreamReset test because the first ReadRows request contains one empty row range instead of no row ranges at all due to this change. The test should allow this first request for a full table scan to be slightly different from other clients as this was done for the TestReadRows_Retry_PausedScan test.

Alternative considered

If we move the code that adds an empty range to execute after the first request when the first error is handled then TestReadRows_Retry_StreamReset will pass without these changes. This client library change is probably not worth the risk at least until an audit is done that will catch all side effects.

Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@danieljbruce danieljbruce marked this pull request as ready for review December 12, 2024 16:12
@danieljbruce danieljbruce requested a review from mutianf December 12, 2024 16:17
@mutianf mutianf merged commit c78ca18 into main Dec 12, 2024
4 checks passed
@mutianf mutianf deleted the stream-reset-fix branch December 12, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants