Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-0231 Batch methods: Get #260

Merged
merged 7 commits into from
Oct 29, 2019
Merged

AIP-0231 Batch methods: Get #260

merged 7 commits into from
Oct 29, 2019

Conversation

michaelwq
Copy link
Contributor

  1. implement AIP-0231 Batch methods: Get
  2. import "github.com/kjk/inflect" to check the plural or singular form of a word

@michaelwq
AIP-0231 Batch methods: Get
2ebfd9e 
import "github.com/kjk/inflect" to check the plural or singular form of a word
@michaelwq michaelwq requested review from a team and lukesneeringer October 26, 2019 00:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2019
mingzhi
mingzhi suggested changes Oct 28, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
rules/aip0231/message_rules.go Outdated Show resolved Hide resolved
rules/aip0231/message_rules.go Outdated Show resolved Hide resolved
rules/aip0231/message_rules.go Outdated Show resolved Hide resolved
rules/aip0231/method_rules.go Outdated Show resolved Hide resolved
rules/aip0231/method_rules.go Outdated Show resolved Hide resolved
@michaelwq michaelwq requested a review from mingzhi October 29, 2019 16:10
mingzhi
mingzhi reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@mingzhi mingzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WANT_LGTM = lukesneeringer@
Thank you Mike!!!

rules/aip0231/aip0231.go Outdated Show resolved Hide resolved
@lukesneeringer lukesneeringer merged commit ec6f0ba into master Oct 29, 2019
@lukesneeringer lukesneeringer deleted the corp-rules2 branch October 29, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingzhi mingzhi mingzhi approved these changes

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelwq @lukesneeringer @mingzhi @googlebot