Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax map_src argument bound to FnOnce #2012

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Relax map_src argument bound to FnOnce #2012

merged 2 commits into from
Nov 4, 2024

Conversation

jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Nov 4, 2024

Fixes #2009

@jswrenn jswrenn requested a review from joshlf November 4, 2024 16:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.59%. Comparing base (c3f7844) to head (8bb217d).
Report is 1 commits behind head on v0.8.x.

Files with missing lines Patch % Lines
src/error.rs 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           v0.8.x    #2012   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          16       16           
  Lines        5988     5988           
=======================================
  Hits         5245     5245           
  Misses        743      743

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joshlf
joshlf requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also release the next 0.8 version in this PR?

@jswrenn jswrenn enabled auto-merge November 4, 2024 16:28
@jswrenn jswrenn disabled auto-merge November 4, 2024 16:29
@jswrenn jswrenn enabled auto-merge November 4, 2024 16:33
@jswrenn
Copy link
Collaborator Author

jswrenn commented Nov 4, 2024

@joshlf version bumped!

@jswrenn jswrenn added this pull request to the merge queue Nov 4, 2024
Merged via the queue into v0.8.x with commit 1fb6365 Nov 4, 2024
87 checks passed
@jswrenn jswrenn deleted the relax-map_src branch November 4, 2024 17:06
@dmgolembiowski
Copy link

This appears to be a semver breaking change. Could a new function name, like map_with, be created instead with the new relaxed bound?

@jswrenn
Copy link
Collaborator Author

jswrenn commented Nov 4, 2024

Why is it a breaking change? FnOnce is a supertrait of Fn, so all arguments that were previously accepted because they were Fn should still be accepted now that the bound has been relaxed to FnOnce.

@dmgolembiowski
Copy link

Apologies @jswrenn, you're right

joshlf pushed a commit that referenced this pull request Nov 5, 2024
@jswrenn @joshlf
Relax map_src argument bound to FnOnce (#2012)
e8d3bda 
* Relax `map_src` argument bound to `FnOnce`

Fixes #2009

* Release v0.8.9
github-merge-queue bot pushed a commit that referenced this pull request Nov 6, 2024
@joshlf @jswrenn
Relax map_src argument bound to FnOnce (#2012) (#2028)
3bcf6f3 
* Relax `map_src` argument bound to `FnOnce`

Fixes #2009

* Release v0.8.9

Co-authored-by: Jack Wrenn <jswrenn@amazon.com>
@joshlf
Copy link
Member

joshlf commented Nov 6, 2024

Backported in #2028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlf joshlf joshlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jswrenn @codecov-commenter @dmgolembiowski @joshlf