Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on default features of dependencies #481

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

ia0
Copy link
Member

@ia0 ia0 commented May 24, 2024

This improves compile times and is more explicit. This used to be true for published libraries, but published binaries also matter.

@ia0 ia0 added the for:maintainability Improves maintainers life label May 24, 2024
@ia0 ia0 changed the title Permit api-{desc,macro} to have dependencies with default features Do not rely on default features of dependencies May 24, 2024
@ia0 ia0 merged commit 900efde into google:main May 24, 2024
19 checks passed
@ia0 ia0 deleted the default branch May 24, 2024 15:06
kofls pushed a commit to kofls/wasefire that referenced this pull request Jul 22, 2024
This improves compile times and is more explicit. This used to be true
for published libraries, but published binaries also matter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for:maintainability Improves maintainers life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant