Skip to content

Commit

Permalink
Add support for --incompatible_config_setting_private_default_visibility
Browse files Browse the repository at this point in the history
bazelbuild/bazel#12933 indicates this is an older flag, from 2021. But I ran into this with `bazelisk --migrate` (https://github.com/bazelbuild/bazelisk#--migrate) and thought it'd be nice to support it.

PiperOrigin-RevId: 712990438
Change-Id: Ie0282401b44d505e2e34117b1d1dc22aa3380c02
  • Loading branch information
TCMalloc Team authored and copybara-github committed Jan 7, 2025
1 parent f852823 commit b6563db
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ build --cxxopt='-std=c++17'
# https://github.com/bazelbuild/bazel/pull/15327 for details.
build --incompatible_disallow_empty_glob

# Flip incompatible_config_setting_private_default_visibility to avoid breaking
# forward compatibility. See https://github.com/bazelbuild/bazel/issues/12933
# for details.
common --incompatible_config_setting_private_default_visibility

# Link Google Test against Abseil and RE2.
build --define='absl=1'

Expand Down
1 change: 1 addition & 0 deletions tcmalloc/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ config_setting(
flag_values = {
"@bazel_tools//tools/cpp:compiler": "clang",
},
visibility = ["//tcmalloc:__subpackages__"],
)

cc_library(
Expand Down

0 comments on commit b6563db

Please sign in to comment.