This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Fix tests to use proper select() for python version #102
Assignees
Comments
brandjon
added a commit
that referenced
this issue
May 10, 2019
This adds a hook file for run_tests.sh to write toolchain info to before each bazel invocation. This replaces the legacy way of passing an interpreter in via --python_path. It also replaces a config_setting that was used to control whether PY2 or PY3 was used, with a simple constant symbol consumed at loading time. This is needed in order to make the target aware at analysis time of which version it is building for. Fixes #98, fixes #102.
brandjon
added a commit
that referenced
this issue
May 13, 2019
This adds a hook file for run_tests.sh to write toolchain info to before each bazel invocation. This replaces the legacy way of passing an interpreter in via --python_path. It also replaces a config_setting that was used to control whether PY2 or PY3 was used, with a simple constant symbol consumed at loading time. This is needed in order to make the target aware at analysis time of which version it is building for. Fixes #98, fixes #102.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Looks like
//tests:version_testrelies on a custom flag to get the Python version. It should use@bazel_tools//tools/python:PY[2|3]. This may cause problems once--incompatible_use_python_toolchainsis enabled (#98).The text was updated successfully, but these errors were encountered: