resolve: disallow augmented assignments at toplevel #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...unless -globalreassign is set. Formerly, the Go implementation permitted x+=y on the basis that we couldn't statically tell whether x was a list (in which case x+=y means x.extend(y), which is not a rebinding), or some other type, in which case it is a forbidden rebinding. This change makes it match the Java implementation. See bazelbuild/starlark#20 (comment) Most non-Bazel-like clients of Starlark set the -globalreassign flag. Change-Id: I5477c46c3d4e00dad419528ee2953b8bd6b47a26
|
This change was reviewed and approved as #122. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...unless -globalreassign is set.
Formerly, the Go implementation permitted x+=y on the basis
that we couldn't statically tell whether x was a list (in which
case x+=y means x.extend(y), which is not a rebinding), or some
other type, in which case it is a forbidden rebinding.
This change makes it match the Java implementation.
See bazelbuild/starlark#20 (comment)
Most non-Bazel-like clients of Starlark set the -globalreassign flag.