Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve: enable bitwise (& | ~ ^ << >>) operators always #123

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

adonovan
Copy link
Collaborator

See bazelbuild/starlark#20 (comment)

Change-Id: I595f87b9b777e79065684ee2c29acb6435b232cf
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@adonovan adonovan requested a review from jayconrod January 23, 2019 03:37
@adonovan
Copy link
Collaborator Author

@laurentlb

Copy link
Collaborator

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but may want to resubmit to keep CLA robot happy.

@alandonovan alandonovan merged commit 2f3bb7c into master Jan 30, 2019
@alandonovan alandonovan deleted the allow-bitwise-always branch January 30, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants