Fixed "failed to execute script gui" error when running under PyInstaller #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller.
PyInstaller looks for import statements to determine the script's dependencies. The two Tkinter imports with different capitalization ('Tkinter' and 'tkinter') seemed to confuse the latest version of PyInstaller, and it wasn't including Tkinter in the packaged binary at all, even with --hidden-import Tkinter. The lowercase "tkinter" fallback import is for Python 3 compatibility, and since the script can't currently run under Python 3 for various other reasons, I removed the import. PyInstaller binaries now work again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
PyInstaller looks for import statements to determine the script's dependencies. The two Tkinter imports with different capitalization ('Tkinter' and 'tkinter') seemed to confuse the latest version of PyInstaller, and it wasn't including Tkinter in the packaged binary at all, even with --hidden-import Tkinter. The lowercase "tkinter" fallback import is for Python 3 compatibility, and since the script can't currently run under Python 3 for various other reasons, I removed the import. PyInstaller binaries now work again.