Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the use of flags #114

Merged
merged 7 commits into from
May 18, 2023
Merged

remove the use of flags #114

merged 7 commits into from
May 18, 2023

Conversation

xmenxk
Copy link
Collaborator

@xmenxk xmenxk commented May 17, 2023

#107

remove the use of flags, given that s2a is a library

@xmenxk xmenxk requested a review from matthewstevenson88 May 17, 2023 22:48
matthewstevenson88
matthewstevenson88 reviewed May 18, 2023
View reviewed changes
Copy link
Collaborator

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Kui! Just 2 small comments.

internal/handshaker/service/service.go Show resolved Hide resolved
internal/v2/s2av2.go Show resolved Hide resolved
@xmenxk xmenxk requested a review from matthewstevenson88 May 18, 2023 16:00
@xmenxk xmenxk requested a review from matthewstevenson88 May 18, 2023 16:46
@xmenxk xmenxk merged commit bb60477 into main May 18, 2023
@xmenxk xmenxk deleted the remove-flags branch May 18, 2023 16:55
@quartzmo quartzmo mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewstevenson88 matthewstevenson88 matthewstevenson88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmenxk @matthewstevenson88