Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build aarch64 wheels for Python google-re2 package #337

Closed
alexmv opened this issue Oct 21, 2021 · 9 comments
Closed

Build aarch64 wheels for Python google-re2 package #337

alexmv opened this issue Oct 21, 2021 · 9 comments

Comments

@alexmv
Copy link

alexmv commented Oct 21, 2021

The Python package ships pre-built wheels for x84_64, which is very useful for many developers. However, for development environments on aarch64 (Apple M1, for instance), getting the google-re2 package built becomes rather more complicated.

Would it be possible to also provide aarch64 pre-built wheels for the Python google-re2 package?
@junyer
Copy link
Contributor

junyer commented Oct 22, 2021

It should be possible, I think, by switching from https://github.com/pypa/manylinux to https://github.com/dockcross/dockcross. Unless the latter is unexpectedly and overwhelmingly broken, I can probably get that done in time for the 2021-11-01 release.

@alexmv
Copy link
Author

alexmv commented Oct 22, 2021

That would be very helpful -- thank you!

@junyer
Copy link
Contributor

junyer commented Oct 24, 2021

I started looking into this today. Unfortunately, the showstopper seems to be that auditwheel doesn't work across platforms; see dockcross/dockcross#475 (comment) and also pypa/auditwheel#244 (comment) for more information. I need to look into using QEMU instead, I suppose.

@junyer
Copy link
Contributor

junyer commented Oct 25, 2021

https://github.com/multiarch/qemu-user-static makes using QEMU trivial. Emulation makes compiling quite slow, unsurprisingly, but that's fine because it's for release, not CI.

copybara-service bot pushed a commit that referenced this issue Oct 25, 2021
@junyer
Upload wheels for more platforms to PyPI.
9e2afec 
Fixes #337.

Change-Id: Id9ffbbf44144cba768bfdc5508a30f3862306404
Reviewed-on: https://code-review.googlesource.com/c/re2/+/59352
Reviewed-by: Perry Lorier <perryl@google.com>
Reviewed-by: Paul Wankadia <junyer@google.com>
@junyer junyer closed this as completed Oct 25, 2021
@junyer
Copy link
Contributor

junyer commented Oct 25, 2021 •
edited
Loading

At the risk of stating the obvious, the 2021-11-01 release is about one week away. Enjoy the new wheels. :)

@alexmv
Copy link
Author

alexmv commented Oct 31, 2021

Thank you!

@junyer
Copy link
Contributor

junyer commented Nov 1, 2021

I just released 0.2.20211101 to PyPI. Please confirm that the new wheels work for you.

@alexmv
Copy link
Author

alexmv commented Nov 2, 2021

We've tested, and they work. Thank you for the quick turn-around!

@junyer
Copy link
Contributor

junyer commented Nov 3, 2021

Great to hear. :)

@andersk andersk mentioned this issue Nov 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexmv @junyer