-
Notifications
You must be signed in to change notification settings - Fork 359
Conversation
Also make the example in the README a bit more universal.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
The tests failed because the % will convert a bytes string to |
Ping? Is this worth merging still? |
The default value is a bytearray. So if the value is a str, just convert it to a bytearray before continuing. In py3, this converts unicode str to bytes. In py2, this converts bytes to bytearray, which is then just joined back into bytes.
I believe this is fixed. You should be able to merge it. |
Is this necessary with #128 merged in? |
Probably not anymore. It looks like #128 has my changes in it. |
Also make the example in the README a bit more universal.