Avoid private override via mixin

This is now an error in strong mode. See: dart-lang/sdk#28809 BUG= R=kevmoo@google.com Review-Url: https://codereview.chromium.org//2778923002 .
google · Mar 27, 2017 · 814653b · 814653b
1 parent 8010b70
commit 814653b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/src/protobuf/generated_message.dart b/lib/src/protobuf/generated_message.dart
@@ -50,7 +50,7 @@ abstract class GeneratedMessage {
 
   UnknownFieldSet get unknownFields => _fieldSet._ensureUnknownFields();
 
-  bool get _isReadOnly => false;
+  bool get _isReadOnly => this is ReadonlyMessageMixin;
 
   bool hasRequiredFields() => info_.hasRequiredFields;
 

diff --git a/lib/src/protobuf/readonly_message.dart b/lib/src/protobuf/readonly_message.dart
@@ -8,8 +8,6 @@ part of protobuf;
 abstract class ReadonlyMessageMixin {
   BuilderInfo get info_;
 
-  bool get _isReadOnly => true;
-
   void addExtension(Extension extension, var value) =>
       _readonly("addExtension");