Add the generated source folders to Eclipse classpath entries

[jdneo]

• add the generated source folders to Eclipse classpath entries. Due to
  a limition of Buildship, we have to create those folders beforehand,
  see: Allow optional source directory to be added into project classpath eclipse-buildship/buildship#1196

Signed-off-by: sheche sheche@microsoft.com

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[ejona86]

We've been in the process of reworking things so the explicit IDE configuration should be less necessary. I'd like to put this on hold a bit until some of the rework is merged and then I'd like you to re-test. What I expect in the future is the generated code should work fine without IDE configuration, but we may still need IDE configuration for .proto files.

[jdneo]

Thank you for the information @ejona86!

To share more background: I'm working on Java language support in VS Code. We received a few feedbacks that VS Code could not recognize the source output directories from protobuf. That's why this PR is raised.

Is it possible to share more information about the generated code should work fine without IDE configuration? Does that mean that the protobuf plugin will generate the sources directly into the existing sourcesets?

[rougsig]

The Protobuf plugin will add the generated folders to the existing source sets. Just like you do it for eclipse, but through the vanilla gradle api, without eclipse plugin.

[jdneo]

Thank you @rougsig.

What I did is to add those protobuf generated folders under the build folder to the Eclipse classpath entries.

If protobuf plugin can generate java source files into existing source sets, then I guess we can forget about the works in this PR. Since existing source sets should already contained in the classpath entries.

Could you please let me know once the rework is done? I'm glad to do some tests in VS Code and Eclipse. :)

[rougsig]

I'll plan to do this week, most likely it will be either Friday or Sunday. Can you create commits with tests? I will start working with them.

[jdneo]

What kind of tests would you like to have?

[rougsig]

We need to make sure that vscode, idea, eclipse have generated code in their models (classpath). Like test in this PR.

[jdneo]

I see. In the backend, VS Code and Eclipse share the same model. If it works in Eclipse, so do VS Code.

So, should I create another PR only contains test code? Or just leave as it is now?

[rougsig]

I see. In the backend, VS Code and Eclipse share the same model. If it works in Eclipse, so do VS Code.

Perfect!

So, should I create another PR only contains test code? Or just leave as it is now?

As you wish, I can cherry-pick the test.

[jdneo]

As you wish, I can cherry-pick the test.

Thank you, I'll leave it here then.

[jdneo]

Close since we have #590 already.