Skip to content

Commit

Permalink
Remove useless classpath attributes
Browse files Browse the repository at this point in the history
Signed-off-by: Sheng Chen <sheche@microsoft.com>
  • Loading branch information
jdneo authored and rougsig committed Aug 29, 2022
1 parent 44cfe40 commit 13b8c1b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 0 additions & 3 deletions src/main/groovy/com/google/protobuf/gradle/Utils.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,6 @@ class Utils {
entry.entryAttributes.put("optional", "true")
entry.entryAttributes.put("ignore_optional_problems", "true")

entry.entryAttributes.put("gradle_scope", isTest ? "test" : "main")
entry.entryAttributes.put("gradle_used_by_scope", isTest ? "test" : "main,test")

// this attribute is optional, but it could be useful for IDEs to recognize that it is
// generated source folder from protobuf, thus providing some support for that.
// e.g. Hint user to run generate tasks if the folder is empty or does not exist.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -442,9 +442,9 @@ class ProtobufJavaPluginTest extends Specification {
if (path.startsWith("build/generated/source/proto")) {
if (path.contains("test")) {
// test source path has one more attribute: ["test"="true"]
assert it.attributes.attribute.size() == 6
assert it.attributes.attribute.size() == 4
} else {
assert it.attributes.attribute.size() == 5
assert it.attributes.attribute.size() == 3
}
}
}
Expand Down

0 comments on commit 13b8c1b

Please sign in to comment.