Add support for determineversions API (#612). #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested on https://github.com/opencv/opencv We need to set up an e2e test for this as well (maybe add some submodules + vendored libs to https://github.com/ossf-tests/scorecard-check-osv-e2e). ``` Scanning dir /tmp/opencv Scanning /tmp/opencv/ at commit e9e6b1e22c1a966a81aca1217b16a51fe7311b3b Scanning directory for vendored libs: /tmp/opencv/3rdparty Scanning potential vendored dir: /tmp/opencv/3rdparty/carotene ... Scanning potential vendored dir: /tmp/opencv/3rdparty/libjpeg Identified /tmp/opencv/3rdparty/libjpeg as https://github.com/libjpeg-turbo/libjpeg-turbo at 9fc018fd1aa9598f21c9bc4d8d53c0cef007bdcf. Scanning potential vendored dir: /tmp/opencv/3rdparty/libjpeg-turbo Identified /tmp/opencv/3rdparty/libjpeg-turbo as https://github.com/libjpeg-turbo/libjpeg-turbo at c5f269eb9665435271c05fbcaf8721fa58e9eafa. Scanning potential vendored dir: /tmp/opencv/3rdparty/libpng ... Scanning potential vendored dir: /tmp/opencv/3rdparty/libwebp Identified /tmp/opencv/3rdparty/libwebp as https://chromium.googlesource.com/webm/libwebp at fd7bb21c0cb56e8a82e9bfa376164b842f433f3b. Scanning potential vendored dir: /tmp/opencv/3rdparty/openexr ... Scanning potential vendored dir: /tmp/opencv/3rdparty/zlib Scanning directory for vendored libs: /tmp/opencv/modules/core/3rdparty Scanning potential vendored dir: /tmp/opencv/modules/core/3rdparty/SoftFloat Scanning directory for vendored libs: /tmp/opencv/modules/features2d/3rdparty Scanning potential vendored dir: /tmp/opencv/modules/features2d/3rdparty/mscr Scanned /tmp/opencv/platforms/maven/opencv/pom.xml file and found 0 packages ... Scanned /tmp/opencv/platforms/maven/opencv-it/pom.xml file and found 12 packages ... +-------------------------------------+------+-----------+---------------------+---------------------+----------------------------------------------------------------------------------- | OSV URL | CVSS | ECOSYSTEM | PACKAGE | VERSION | SOURCE +-------------------------------------+------+-----------+---------------------+---------------------+----------------------------------------------------------------------------------- | https://osv.dev/OSV-2022-394 | | GIT | e9e6b1e22c1a966a81aca1217b16a51fe7311b3b | ../../../../../../tmp/opencv | https://osv.dev/OSV-2023-444 | | GIT | e9e6b1e22c1a966a81aca1217b16a51fe7311b3b | ../../../../../../tmp/opencv | https://osv.dev/CVE-2021-29390 | 7.1 | GIT | 9fc018fd1aa9598f21c9bc4d8d53c0cef007bdcf | ../../../../../../tmp/opencv/3rdparty/libjpeg | https://osv.dev/CVE-2021-46822 | 5.5 | GIT | 9fc018fd1aa9598f21c9bc4d8d53c0cef007bdcf | ../../../../../../tmp/opencv/3rdparty/libjpeg | https://osv.dev/CVE-2023-4863 | 8.8 | GIT | fd7bb21c0cb56e8a82e9bfa376164b842f433f3b | ../../../../../../tmp/opencv/3rdparty/libwebp ... ```
This was referenced Oct 30, 2023
hogo6002
approved these changes
Oct 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #621 +/- ##
==========================================
- Coverage 80.33% 78.82% -1.52%
==========================================
Files 78 78
Lines 5406 5511 +105
==========================================
+ Hits 4343 4344 +1
- Misses 887 990 +103
- Partials 176 177 +1
|
|
Do we want this behind a flag rather than by default? It does significantly increase scanning time |
another-rex
approved these changes
Nov 1, 2023
|
Thanks for the fixes!
Hmm, we can always add this in if people ask for it. We can also optimize things using goroutines a you mention. It does make things slower, but only when they have these specific set of directories that likely indicate they're using vendored libs and would want this on by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #612.
Tested on https://github.com/opencv/opencv
We need to set up an e2e test for this as well (maybe add some submodules + vendored libs to https://github.com/ossf-tests/scorecard-check-osv-e2e).