-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Polish up documentation CSS and font #1552
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
=======================================
Coverage 69.31% 69.31%
=======================================
Files 200 200
Lines 19038 19038
=======================================
Hits 13196 13196
Misses 5135 5135
Partials 707 707 ☔ View full report in Codecov by Sentry. |
the new heading looks not bold enough to me - can we improve this? |
Hmm... I think it looks alright? If you look at just the docs https://just-the-docs.com/docs/ui-components/typography/ it's about the same, I can bump up the font weight a bit, but it's supposed to be thin. |
I agree with Xueqin - it feels a little unbalanced. I think having the heading 1 font weight matching the heading 2 font weight feels better (so both at 500). That or bring back Overpass just for the headings - I liked that font lol. |
Reverted the heading fonts to overpass now :) (will take a second to deploy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
New version of docs: https://another-rex.github.io/osv-scanner/supported-languages-and-lockfiles/
Old version of docs: https://google.github.io/osv-scanner/supported-languages-and-lockfiles/