-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add nix
to projects (using nix
)
#6317
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
nix
to projectsnix
to the projects (using nix
)
nix
to the projects (using nix
)nix
to projects (using nix
)
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
9e768ba
to
7cca56f
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I am having a hard time building for coverage, see #6385 . |
@googlebot I signed it! |
About integrating the fuzz targets, and related
So: |
* in development only * to be removed from the PR Signed-off-by: Pamplemousse <xav.maso@gmail.com>
7cca56f
to
12a1472
Compare
As I am struggling to integrate
nix
to OSS-fuzz, these PR (with #6338) helps to keep track of the progress, and help gather feedback on approaches taken.Context
As part of a fellowship, I work on fuzzing
nix
; More details on https://discourse.nixos.org/t/tweag-fellowship-fuzzing-nix-0 .One of the "end-goal" of the project is to integrate
nix
to OSS-fuzz; This PR is a step in that direction.Approach
Unlike #6338;
This approach aims to stay "close" to the build system used upstream to avoid maintenance burden:
nix
to:Dockerfile
; no extra management of dependencies)$OUT
)nix
libraries without hasslelib*_LDFLAGS
NixOS/nix#5175) for better fuzzer coverage and sanitization(Another pretty similar approach would be to compile statically using
pkgsStatic
packages fromnixpkgs
in upstream'sflake.nix
, but this is not well supported, and many such packages currently fail to build...)Disadvantage: does not work (yet).
TODO
nix
librariesclang
environmentintegrate fuzz targets upstreamNO (see [WIP] Addnix
to projects (usingnix
) #6317 (comment))integrateNO (see [WIP] Addlocal.mk
upstreamnix
to projects (usingnix
) #6317 (comment))auto_ccs
toprojects.yaml
if maintainers are OKcc @regnat