infra: add javascript as a language with builder img #11106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: #11103 Signed-off-by: David Korczynski <david@adalogics.com>
|
Also adjusts some formatting which showed up when running |
DonggeLiu
approved these changes
Oct 21, 2023
jonathanmetzman
approved these changes
Oct 23, 2023
| default=constants.DEFAULT_LANGUAGE, | ||
| choices=['c', 'c++', 'rust', 'go', 'jvm', 'swift', 'python', 'javascript'], | ||
| help='Project language.') | ||
| generate_parser.add_argument('--language', |
There was a problem hiding this comment.
Maybe create a list from LANGUAGES_WITH_BUILDER_IMAGES and add C, C++ to it.
There was a problem hiding this comment.
Updated, but LANGUAGES_WITH_BUILDER_IMAGES to be a mapping rather than a list, wdyt?
Signed-off-by: David Korczynski <david@adalogics.com>
oliverchang
reviewed
Nov 23, 2023
Signed-off-by: David Korczynski <david@adalogics.com>
oliverchang
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #11103