remove MPSWriteError

google · Nov 13, 2023 · d750959 · d750959
1 parent fddaba4
commit d750959
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 30 deletions.
diff --git a/ortools/linear_solver/BUILD.bazel b/ortools/linear_solver/BUILD.bazel
@@ -204,7 +204,6 @@ cc_library(
         "linear_solver_callback.h",
         "scip_callback.h",
         "scip_helper_macros.h",
-        "MPSWriteError.h",
     ] + select({
         ":use_glop": ["glop_utils.h"],
         "//conditions:default": [],

diff --git a/ortools/linear_solver/MPSWriteError.h b/ortools/linear_solver/MPSWriteError.h
diff --git a/ortools/linear_solver/linear_solver.h b/ortools/linear_solver/linear_solver.h
@@ -1663,7 +1663,7 @@ class MPSolverInterface {
   }
 
   // Writes the model using the solver internal write function.  Currently only
-  // available for GurobiInterface.
+  // available for GurobiInterface and XpressInterface.
   virtual void Write(const std::string& filename);
 
   // ----- Model modifications and extraction -----

diff --git a/ortools/linear_solver/xpress_interface.cc b/ortools/linear_solver/xpress_interface.cc
@@ -25,8 +25,6 @@
 #include "absl/strings/str_format.h"
 #include "ortools/base/logging.h"
 #include "ortools/base/timer.h"
-#include "ortools/base/types.h"
-#include "ortools/linear_solver/MPSWriteError.h"
 #include "ortools/linear_solver/linear_solver.h"
 #include "ortools/xpress/environment.h"
 
@@ -2093,7 +2091,7 @@ void XpressInterface::Write(const std::string& filename) {
   VLOG(1) << "Writing Xpress MPS \"" << filename << "\".";
   const int status = XPRSwriteprob(mLp, filename.c_str(), "");
   if (status) {
-    throw MPSWriteError("Failed to write MPS.");
+    LOG(ERROR) << "Xpress: Failed to write MPS! ";
   }
 }