-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more accessible names to the console #2652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 16 of 16 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ptkach)
console-webapp/src/app/settings/settings.component.html
line 28 at r2 (raw file):
[active]="rla2.isActive" aria-label="Access whois settings" >WHOIS Info</a
this has nothing to do with this PR but maybe at some point we consider changing this to RDAP instead of WHOIS, just a thought
console-webapp/src/app/users/users.component.html
line 94 at r2 (raw file):
mat-flat-button (click)="isNew = true" aria-label="Create new user"
why get rid of the aria-label here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)
console-webapp/src/app/settings/settings.component.html
line 28 at r2 (raw file):
Previously, gbrodman wrote…
this has nothing to do with this PR but maybe at some point we consider changing this to RDAP instead of WHOIS, just a thought
Sure, we will do this later
console-webapp/src/app/users/users.component.html
line 94 at r2 (raw file):
Previously, gbrodman wrote…
why get rid of the aria-label here?
Because it doesn't provide any more information on this button role more than it's content already does. For example compare that to "Save" buttons in the same PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @ptkach)
678b32e
to
61359cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ptkach)
c7bbda6
to
dc597bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woo fonts
Reviewed 8 of 8 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ptkach)
This change is