Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more accessible names to the console #2652

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

ptkach
Copy link
Collaborator

@ptkach ptkach commented Jan 28, 2025

This change is Reviewable

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 16 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ptkach)


console-webapp/src/app/settings/settings.component.html line 28 at r2 (raw file):

        [active]="rla2.isActive"
        aria-label="Access whois settings"
        >WHOIS Info</a

this has nothing to do with this PR but maybe at some point we consider changing this to RDAP instead of WHOIS, just a thought


console-webapp/src/app/users/users.component.html line 94 at r2 (raw file):

          mat-flat-button
          (click)="isNew = true"
          aria-label="Create new user"

why get rid of the aria-label here?

Copy link
Collaborator Author

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)


console-webapp/src/app/settings/settings.component.html line 28 at r2 (raw file):

Previously, gbrodman wrote…

this has nothing to do with this PR but maybe at some point we consider changing this to RDAP instead of WHOIS, just a thought

Sure, we will do this later


console-webapp/src/app/users/users.component.html line 94 at r2 (raw file):

Previously, gbrodman wrote…

why get rid of the aria-label here?

Because it doesn't provide any more information on this button role more than it's content already does. For example compare that to "Save" buttons in the same PR

Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ptkach)

@ptkach ptkach force-pushed the consoleGar2 branch 2 times, most recently from 678b32e to 61359cb Compare January 28, 2025 21:38
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ptkach)

@ptkach ptkach force-pushed the consoleGar2 branch 2 times, most recently from c7bbda6 to dc597bf Compare January 29, 2025 19:04
Copy link
Collaborator

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo fonts

Reviewed 8 of 8 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ptkach)

@ptkach ptkach enabled auto-merge January 29, 2025 19:47
@ptkach ptkach added this pull request to the merge queue Jan 29, 2025
Merged via the queue into google:master with commit 765bd98 Jan 29, 2025
9 checks passed
@ptkach ptkach deleted the consoleGar2 branch January 29, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants