-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace android.support references with androidx #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dthkao, @xpconanfan, and @winterfroststrom)
tests/mobly/base_instrumentation_test_test.py, line 421 at r1 (raw file):
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:59) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at androidx.test.internal.runner.junit4.statement.RunBefores.evaluate(RunBefores.java:80)
so there's no change in the paths of the classes referred to in these stacktraces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dthkao and @winterfroststrom)
tests/mobly/base_instrumentation_test_test.py, line 421 at r1 (raw file):
Previously, xpconanfan (Ang Li) wrote…
so there's no change in the paths of the classes referred to in these stacktraces?
Nope: please see the linked explanation in the PR description and scroll down to "Revised naming for packages and Maven artifacts". Also these are part of an example stacktrace and don't figure into the unit tests at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @xpconanfan, @dthkao, and @winterfroststrom)
mobly/base_instrumentation_test.py, line 86 at r1 (raw file):
android.app.Instrumentation androidx.test.internal.runner.listener.InstrumentationResultPrinter
This is doesn't not seem to exist right now in the googlesource repo?
So, that's going to be an invalid documentation link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @xpconanfan and @dthkao)
mobly/base_instrumentation_test.py, line 86 at r1 (raw file):
Previously, winterfroststrom wrote…
This is doesn't not seem to exist right now in the googlesource repo?
So, that's going to be an invalid documentation link?
Clarified this a bit better. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @xpconanfan and @winterfroststrom)
mobly/base_instrumentation_test.py, line 86 at r1 (raw file):
Previously, dthkao (David T.H. Kao) wrote…
Clarified this a bit better. WDYT?
assuming this unblocks you, seems fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @xpconanfan)
tests/mobly/base_instrumentation_test_test.py, line 421 at r1 (raw file):
Previously, dthkao (David T.H. Kao) wrote…
Nope: please see the linked explanation in the PR description and scroll down to "Revised naming for packages and Maven artifacts". Also these are part of an example stacktrace and don't figure into the unit tests at all.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @xpconanfan and @dthkao)
mobly/base_instrumentation_test.py, line 88 at r2 (raw file):
android.support.test.internal.runner.listener.InstrumentationResultPrinter Note: android.support.* is in the process of being converted to androidx.*,
i'm not sure if we should refer to this so specifically.
what is the plan to remove this time-sensitive info?
Might be easier to simply change the reference in code block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @xpconanfan and @dthkao)
mobly/base_instrumentation_test.py, line 88 at r2 (raw file):
Previously, xpconanfan (Ang Li) wrote…
i'm not sure if we should refer to this so specifically.
what is the plan to remove this time-sensitive info?Might be easier to simply change the reference in code block?
made it a todo with reference to blogpost
See https://android-developers.googleblog.com/2018/05/hello-world-androidx.html
This change is