Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added require('material-design-icons').STATIC_PATH #279

Merged
merged 1 commit into from
Dec 30, 2015

Conversation

appsforartists
Copy link
Member

It would improve the developer ergonomics if we made hosting this package as easy as possible.

For instance, if you are working on an app locally/offline and want to use Material assets, with this change you'd be able to:

server.map(
  STATIC_PREFIX + '/material-design-icons',
  require('material-design-icons').STATIC_PATH,
);

and all the icons in this package would be available at http://localhost:8080/static/material-design-icons/ Of course, you'd want something more robust for production, but this would be an improvement for development.

Thoughts, @shyndman, @jestelle?

shyndman pushed a commit that referenced this pull request Dec 30, 2015
Added require('material-design-icons').PATH
@shyndman shyndman merged commit 92ef568 into google:master Dec 30, 2015
@appsforartists appsforartists added this to the v2.2 milestone Dec 30, 2015
@appsforartists appsforartists changed the title Added require('material-design-icons').PATH Added require('material-design-icons').STATIC_PATH Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants