-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CSS file for Icon Font & modified bower.json #216
Conversation
…s to main block in bower.json for flexible use with bower-installer
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Hey @otomeskhy, Change looks good, but why was the main section introduced to the bower file? |
Hey @shyndman , That section makes sure that bower-installer ( https://github.com/blittle/bower-installer ) will know which dependencies are needed for people who uses this repo as Bower package. Generally other files do not do anything bad, but if you use package with Cordova, it gets bigger and heavier because of the files you don't use. So, with this, bower-install extract only web fonts and you can use them in your project without using other files. |
We have plans to split out the repo into platform/approach-specific subsets, so I don't think the main section is appropriate. Could you revert |
Sounds fair. bower.json file reverted. Thanks. |
Added CSS file for Icon Font.
until there is no main section in bower.json file, you can put this on your bower.json project: "overrides": {
"material-design-icons": {
"main": [
"index.js",
"iconfont/material-icons.css",
"iconfont/MaterialIcons-Regular.woff2",
"iconfont/MaterialIcons-Regular.woff",
"iconfont/MaterialIcons-Regular.ttf"
]
}
} This solve problem when |
As you can see, we removed it because of plans to split repo into platform-specific ones. I am not sure if that happened or not in the end, haven't been into world of front-end lately. But, Pablo's solution should work, yeah. |
Added CSS file for Icon Font so they are usable right from package without additional work (copy + paste it is). Also added that new CSS file and Icon Font files to main block of bower.json so they are usable with bower-installer (for the folks that need only Icon Font)