add else to when #869
Merged
add else to when #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
Thanks! Could you sign the CLA so that we can merge it? |
ting-yuan
reviewed
Feb 23, 2022
| @@ -235,41 +235,41 @@ internal fun ModuleClassResolver.resolveContainingClass(psiMethod: PsiMethod): C | |||
| } | |||
|
|
|||
| internal fun getInstanceForCurrentRound(node: KSNode): KSNode? { | |||
| when (node.origin) { | |||
| return when (node.origin) { | |||
| Origin.KOTLIN_LIB, Origin.JAVA_LIB -> return null | |||
There was a problem hiding this comment.
Could you remove the return in return null?
There was a problem hiding this comment.
done.
thank you for telling me
|
can you fix the ktlint error? |
@neetopia done. |
|
Thanks! I will merge once CI is finished. |
|
Merged, thanks for your PR! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
* add else to when * remove the return in return null (cherry picked from commit 504e184)
ting-yuan
pushed a commit
to ting-yuan/ksp
that referenced
this pull request
Apr 8, 2022
* add else to when * remove the return in return null (cherry picked from commit 504e184)
ting-yuan
pushed a commit
that referenced
this pull request
Apr 8, 2022
* add else to when * remove the return in return null (cherry picked from commit 504e184)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I know this will be updated in Kotlin 1.6.
It seems to be a violation of this, so I will correct it and PR.
thank you.