Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting closed connections from the connections map #139

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

hareeshv
Copy link
Contributor

@hareeshv hareeshv commented Oct 2, 2024

After extensive testing we found that the connections map hosting correct setup of connections:
$ docker logs ba-proxy-agent 2>&1 | grep "attempt to read data from a closed session" | wc
2479 27269 174902
$ docker logs -f ba-proxy-agent --tail 10
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3141
, total sessions: 662
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3143
, total sessions: 663
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3142
, total sessions: 664
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3144
, total sessions: 665
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3145
, total sessions: 666

After extensive testing we found that the connections map hosting correct setup of connections:
 $ docker logs  ba-proxy-agent 2>&1 | grep "attempt to read data from a closed session" | wc
   2479   27269  174902
 $ docker logs -f ba-proxy-agent --tail 10
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3141
, total sessions: 662
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3143
, total sessions: 663
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3142
, total sessions: 664
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3144
, total sessions: 665
2024/09/26 10:57:28 Websocket connection to the server "ws://localhost:8094/websocket-shim/" established for session: 3145
, total sessions: 666
Copy link

google-cla bot commented Oct 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ojarjur ojarjur merged commit 4f3c733 into google:master Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants