Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert buffer changes #472

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Revert buffer changes #472

merged 1 commit into from
Aug 4, 2022

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Aug 4, 2022

WHAT

Revert https://github.com/google/horologist/pull/457/files

WHY

Breaking, possibly a beta02 vs master issue.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from kul3r4 August 4, 2022 14:57
@yschimke
Copy link
Collaborator Author

yschimke commented Aug 4, 2022

:18.842 31886-31886 AndroidRuntime          com....horologist.mediasample.debug  E  FATAL EXCEPTION: main
                                                                                                    Process: com.google.android.horologist.mediasample.debug, PID: 31886
                                                                                                    java.lang.IllegalAccessError: Illegal class access: 'com.google.android.horologist.media3.config.WearMedia3Factory' attempting to access 'androidx.media3.exoplayer.audio.DefaultAudioSink$AudioTrackBufferSizeProvider' (declaration of 'com.google.android.horologist.media3.config.WearMedia3Factory' appears in /data/app/~~SSMzZuSnmv23PV7Y3ufoQg==/com.google.android.horologist.mediasample.debug-VTZdhGgUmVSTlZZprKmV_Q==/base.apk!classes5.dex)
                                                                                                    	at com.google.android.horologist.media3.config.WearMedia3Factory.audioSink(WearMedia3Factory.kt:44)
                                                                                                    	at com.google.android.horologist.mediasample.di.MediaApplicationModule.audioSink(MediaApplicationModule.kt:117)
                                                                                                    	at com.google.android.horologist.mediasample.di.MediaApplicationModule_AudioSinkFactory.audioSink(MediaApplicationModule_AudioSinkFactory.java:45)
                                                                                                    	at com.google.android.horologist.mediasample.ui.app.DaggerMediaApplication_HiltComponents_SingletonC$SingletonCImpl$SwitchingProvider.get(DaggerMediaApplication_HiltComponents_SingletonC.java:1263)
                                                                                                    	at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
                                                                                                    	at com.google.android.horologist.mediasample.ui.app.DaggerMediaApplication_HiltComponents_SingletonC$ServiceCImpl$SwitchingProvider.get(DaggerMediaApplication_HiltComponents_SingletonC.java:948)
                                                                                                    	at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
                                                                                                    	at com.google.android.horologist.mediasample.ui.app.DaggerMediaApplication_HiltComponents_SingletonC$ServiceCImpl$SwitchingProvider.get(DaggerMediaApplication_HiltComponents_SingletonC.java:942)
                                                                                                    	at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
                                                                                                    	at com.google.android.horologist.mediasample.ui.app.DaggerMediaApplication_HiltComponents_SingletonC$ServiceCImpl$SwitchingProvider.get(DaggerMediaApplication_HiltComponents_SingletonC.java:939)
                                                                                                    	at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
                                                                                                    	at com.google.android.horologist.mediasample.ui.app.DaggerMediaApplication_HiltComponents_SingletonC$ServiceCImpl$SwitchingProvider.get(DaggerMediaApplication_HiltComponents_SingletonC.java:936)
                                                                                                    	at dagger.internal.DoubleCheck.get(DoubleCheck.java:47)
                                                                                                    	at com.google.android.horologist.mediasample.ui.app.DaggerMediaApplication_HiltComponents_SingletonC$ServiceCImpl.injectPlaybackService2(DaggerMediaApplication_HiltComponents_SingletonC.java:906)
                                                                                                    	at com.google.android.horologist.mediasample.ui.app.DaggerMediaApplication_HiltComponents_SingletonC$ServiceCImpl.injectPlaybackService(DaggerMediaApplication_HiltComponents_SingletonC.java:878)
                                                                                                    	at com.google.android.horologist.mediasample.data.service.playback.Hilt_PlaybackService.inject(Hilt_PlaybackService.java:51)
                                                                                                    	at com.google.android.horologist.mediasample.data.service.playback.Hilt_PlaybackService.onCreate(Hilt_PlaybackService.java:28)
                                                                                                    	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4192)
                                                                                                    	at android.app.ActivityThread.access$1500(ActivityThread.java:237)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1932)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loop(Looper.java:223)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7651)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
2022-08-04 15:52:18.854 31886-31886 Process                 com....horologist.mediasample.debug  I  Sending signal. PID: 31886 SIG: 9

@yschimke
Copy link
Collaborator Author

yschimke commented Aug 4, 2022

Reverting because it's breaking in local testing with released media3.

@yschimke yschimke merged commit 7da021a into google:main Aug 4, 2022
@yschimke yschimke deleted the revert branch August 5, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant