Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Provider to avoid creating AudioOffloadManager when disabled. #468

Merged
merged 5 commits into from
Aug 5, 2022
Merged

Use Provider to avoid creating AudioOffloadManager when disabled. #468

merged 5 commits into from
Aug 5, 2022

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Aug 4, 2022 •
edited
Loading

WHAT

Use Provider to avoid creating AudioOffloadManager when disabled.

WHY

Shouldn't be created at all if not required.

HOW

Use a Provider.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke marked this pull request as ready for review August 5, 2022 09:53
@yschimke yschimke merged commit fd23131 into google:main Aug 5, 2022
@yschimke yschimke deleted the offload_manager branch September 21, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yschimke