Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename domain model MediaItem to Media #438

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jul 26, 2022

WHAT

Rename domain model MediaItem to Media.

WHY

In order to avoid confusion with media3's MediaItem model.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp force-pushed the media_rename_mediaitem branch from 748a242 to a5cec0d Compare July 26, 2022 14:17
@luizgrp luizgrp force-pushed the media_rename_mediaitem branch from a5cec0d to cbab507 Compare July 26, 2022 14:21
@luizgrp luizgrp force-pushed the media_rename_mediaitem branch from cbab507 to 484f9b6 Compare July 26, 2022 14:38
@luizgrp luizgrp requested a review from yschimke July 26, 2022 15:06
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@luizgrp luizgrp merged commit 983f393 into google:main Jul 26, 2022
@luizgrp luizgrp deleted the media_rename_mediaitem branch July 26, 2022 15:21
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants