Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the fadeAway logic and implement a sample in the ScratchActivity #429

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Fix the fadeAway logic and implement a sample in the ScratchActivity #429

merged 3 commits into from
Jul 21, 2022

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jul 21, 2022 •
edited
Loading

WHAT

Fix the fadeAway logic and implement a sample in the ScratchActivity

image

WHY

Offset wasn't used in this calculation, and meant a delay before fade.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke marked this pull request as ready for review July 21, 2022 18:51
@yschimke yschimke requested a review from shumelchyk July 21, 2022 18:55
@yschimke yschimke merged commit 51ac86a into google:main Jul 21, 2022
@yschimke yschimke mentioned this pull request Jul 22, 2022
Closed
@yschimke yschimke deleted the timetext branch August 5, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumelchyk shumelchyk Awaiting requested review from shumelchyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yschimke