Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Ksp. #412

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Move to Ksp. #412

merged 2 commits into from
Jul 20, 2022

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jul 19, 2022 •
edited
Loading

WHAT

Advised by DevRel to move to Ksp, which would allow a Kotlin 1.7.0 upgrade at some point.
Working for Room, Moshi, but not for Dagger/Hilt.

WHY

https://issuetracker.google.com/issues/236612358

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke
Move to Ksp.
9bc8501 
Working for Room, Moshi, but not for Dagger/Hilt.
@yschimke yschimke requested a review from shumelchyk July 19, 2022 18:43
@yschimke yschimke mentioned this pull request Jul 20, 2022
Closed
@yschimke
Copy link
Collaborator Author

yschimke commented Jul 20, 2022 •
edited
Loading

@shumelchyk I'll follow up with any review comments, but mostly a mechanical switch.

@yschimke yschimke merged commit 7c15a24 into google:main Jul 20, 2022
@yschimke yschimke deleted the ksp branch August 5, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumelchyk shumelchyk Awaiting requested review from shumelchyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yschimke