Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call clean task with verifyPaparazziDebug #345

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jul 7, 2022

WHAT

Call clean task with verifyPaparazziDebug

WHY

In order to prevent it using cache, in an attempt to fix #339

HOW

  • add clean task to be called with verifyPaparazziDebug;
  • move "snapshot test" step to be executed after "upload test reports" step, due to the clean task that would delete the previously generated reports;
  • change "upload snapshot tests failures" step to also archive the test results and to run "always";

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • [N/A] Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

@luizgrp luizgrp requested a review from yschimke July 7, 2022 16:16
@luizgrp
Copy link
Member Author

luizgrp commented Jul 7, 2022

With this PR, this issue #340 is surfaced again:

> Task :media-ui:testDebugUnitTest
com.google.android.horologist.media.ui.FigmaVolumeScreenTest > volumePlayerScreen FAILED
    java.lang.NullPointerException at FigmaVolumeScreenTest.kt:46

@luizgrp luizgrp merged commit ac7339d into google:main Jul 8, 2022
@luizgrp luizgrp deleted the 339_clean_b4_verifyPaparazziDebug branch July 8, 2022 09:06
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positives by Paparazzi snapshot tests
1 participant