Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use run-affected for unit tests #343

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jul 7, 2022

WHAT

Don't use run-affected param for unit tests.

WHY

In order to not use this plugin which might be causing #340

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • [N/A] Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

@luizgrp
Copy link
Member Author

luizgrp commented Jul 7, 2022

Now the thrill of merging this PR...

It got green in CI but all the verifyPaparazziDebug tasks were "UP-TO-DATE":

...
> Task :media-ui:verifyPaparazziDebug UP-TO-DATE

So probably it's a false positive.

@luizgrp luizgrp merged commit c77ff55 into google:main Jul 7, 2022
@luizgrp luizgrp deleted the stop_using_affectedmoduledetector branch July 7, 2022 15:23
luizgrp added a commit that referenced this pull request Jul 7, 2022
luizgrp added a commit that referenced this pull request Jul 8, 2022
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants