-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI Display when no item or not connected #286
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2909c56
No item
yschimke 79af752
Update UI
yschimke f20943e
Update UI
yschimke 20b023e
Merge branch 'main' into no_item
yschimke 3305ced
Update UI
yschimke 1817cbd
Update UI
yschimke e6877d7
Update UI
yschimke e697a24
Update UI
yschimke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
...src/main/java/com/google/android/horologist/audio/ui/components/actions/SettingsButton.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Copyright 2022 The Android Open Source Project | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.android.horologist.audio.ui.components.actions | ||
|
||
import androidx.compose.foundation.layout.size | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.graphics.Color | ||
import androidx.compose.ui.graphics.vector.ImageVector | ||
import androidx.compose.ui.semantics.semantics | ||
import androidx.wear.compose.material.Button | ||
import androidx.wear.compose.material.ButtonDefaults | ||
import androidx.wear.compose.material.ButtonDefaults.buttonColors | ||
import androidx.wear.compose.material.Icon | ||
import androidx.wear.compose.material.MaterialTheme | ||
import com.google.android.horologist.audio.VolumeState | ||
import com.google.android.horologist.audio.ui.ExperimentalHorologistAudioUiApi | ||
import com.google.android.horologist.audio.ui.semantics.CustomSemanticsProperties.iconImageVector | ||
|
||
/** | ||
* Button to launch a screen to control the system volume. | ||
* | ||
* See [VolumeState] | ||
*/ | ||
@ExperimentalHorologistAudioUiApi | ||
@Composable | ||
public fun SettingsButton( | ||
onClick: () -> Unit, | ||
imageVector: ImageVector, | ||
contentDescription: String, | ||
modifier: Modifier = Modifier, | ||
enabled: Boolean = true, | ||
) { | ||
Button( | ||
modifier = modifier.size(ButtonDefaults.SmallButtonSize), | ||
onClick = onClick, | ||
colors = buttonColors( | ||
backgroundColor = Color.Transparent, | ||
disabledBackgroundColor = Color.Transparent, | ||
contentColor = MaterialTheme.colors.onSurface, | ||
), | ||
enabled = enabled | ||
) { | ||
|
||
Icon( | ||
imageVector = imageVector, | ||
contentDescription = contentDescription, | ||
modifier = Modifier.semantics { iconImageVector = imageVector } | ||
) | ||
} | ||
} |
Binary file modified
BIN
+1.41 KB
(100%)
...ndroid.horologist.audio.ui_VolumeScreenIndividualTest_volumeScreenAtMaximum.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+670 Bytes
(100%)
...ndroid.horologist.audio.ui_VolumeScreenIndividualTest_volumeScreenAtMinimum.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: update kdoc