Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DefaultMediaDisplay #280

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Add DefaultMediaDisplay #280

merged 1 commit into from
Jun 28, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jun 27, 2022

WHAT

Add DefaultMediaDisplay.

Screen Shot 2022-06-27 at 17 31 20

WHY

In order to provide common components.

HOW

  • Add code from media toolkit project;
  • Add preview in debug folder;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp force-pushed the mediaui_defaultmediadisplay branch from 4c5848b to 67eb2e2 Compare June 27, 2022 17:59
@luizgrp luizgrp force-pushed the mediaui_defaultmediadisplay branch from 67eb2e2 to 895be4d Compare June 28, 2022 10:11
@luizgrp luizgrp merged commit 7a8c7ca into google:main Jun 28, 2022
@luizgrp luizgrp deleted the mediaui_defaultmediadisplay branch June 28, 2022 11:01
@luizgrp luizgrp mentioned this pull request Jun 28, 2022
Closed
4 tasks
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke