Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update media title margin for large screens. #2111

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

kpaikena
Copy link
Collaborator

@kpaikena kpaikena commented Mar 11, 2024

WHAT

Update media title margins for large screens.

WHY

To comply with large screen UI/UX guidelines.

HOW

Set margin between title and artist to 4dp for large screen and 2dp for small screen in MarqueeTextMediaDisplay, TextMediaDisplay.
Also fixed media title alignment in TextMediaDisplay, updated LoadingMediaDisplay, and added separate screenshot tests for large screen in LoadingMediaDisplayTest.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorrow looks about 1px higher than the other 3, or I'm imagining it?

Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but failing build, and some comments.

@yschimke
Copy link
Collaborator


com.google.android.horologist.screensizes.MediaPlayerTest > screenshot[6] FAILED
    java.lang.AssertionError at Diffing.kt:154
    
...

com.google.android.horologist.media.ui.MediaPlayerDeviceScreenTest > mediaPlayerScreen FAILED
    java.lang.AssertionError at MediaPlayerDeviceScreenTest.kt:80
    
...    

com.google.android.horologist.media.ui.MediaPlayerScreenTest > mediaPlayerScreen[6] FAILED
    java.lang.AssertionError at MediaPlayerScreenTest.kt:72

...    

com.google.android.horologist.media.ui.PodcastPlayerScreenTest > mediaPlayerScreen[2] FAILED
    java.lang.AssertionError at PodcastPlayerScreenTest.kt:69
    
...    

com.google.android.horologist.media.ui.components.MarqueeTextMediaDisplayTest > givenPaintable_thenImageIsDisplayed FAILED
    java.lang.AssertionError at MarqueeTextMediaDisplayTest.kt:54

@yschimke yschimke closed this Mar 12, 2024
@yschimke yschimke reopened this Mar 12, 2024
@kpaikena kpaikena merged commit c25f407 into google:main Mar 12, 2024
4 checks passed
@kpaikena kpaikena deleted the large-screens-title-margin branch May 29, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants