Add Sign-in prompt #2063
Merged
Add Sign-in prompt #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Feb 23, 2024
...hone/src/main/java/com/google/android/horologist/datalayer/sample/screens/main/MainScreen.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Feb 23, 2024
...android/horologist/datalayer/sample/screens/inappprompts/signin/SignInPromptDemoViewModel.kt
Show resolved
Hide resolved
yschimke
reviewed
Feb 23, 2024
|
|
||
| import kotlinx.coroutines.CoroutineScope | ||
|
|
||
| internal object CoroutineScopeHolder { |
There was a problem hiding this comment.
I'm still curious what this looks like in other similar libraries, but will take a look myself.
Not an issue in practice, or principle, I'm just curious about it.
There was a problem hiding this comment.
please let me know your findings 👍
yschimke
approved these changes
Feb 23, 2024
…gist/datalayer/sample/screens/main/MainScreen.kt Co-authored-by: Yuri Schimke <yuri@schimke.ee>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add Sign-in prompt + sample.
Checklist 📋