Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phone previews #2042

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix phone previews #2042

merged 1 commit into from
Feb 19, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Feb 19, 2024 •
edited
Loading

WHAT

WHY

Don't show up without the debug dependency

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from luizgrp February 19, 2024 12:31
luizgrp
luizgrp approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@yschimke yschimke merged commit 713a2f7 into google:main Feb 19, 2024
4 checks passed
@yschimke yschimke deleted the fix_phone_previews branch March 14, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @luizgrp