Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add id and uri to MediaItem #184

Merged
merged 1 commit into from
May 20, 2022
Merged

Add id and uri to MediaItem #184

merged 1 commit into from
May 20, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented May 19, 2022

WHAT

Add id and uri properties to MediaItem.

WHY

First follow-up from review in #173 (comment)

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp force-pushed the media_improveapi2 branch from e126e86 to cc94ea3 Compare May 19, 2022 18:56
@luizgrp luizgrp requested a review from yschimke May 20, 2022 08:13
yschimke
yschimke reviewed May 20, 2022
View reviewed changes
media/api/current.api Outdated Show resolved Hide resolved
@luizgrp luizgrp force-pushed the media_improveapi2 branch from cc94ea3 to cded6e0 Compare May 20, 2022 09:12
@luizgrp luizgrp merged commit a778657 into google:main May 20, 2022
@luizgrp luizgrp deleted the media_improveapi2 branch May 20, 2022 09:36
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke