Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AppHelperNodeStatus #1827

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Improve AppHelperNodeStatus #1827

merged 1 commit into from
Nov 22, 2023

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Nov 21, 2023 •
edited
Loading

WHAT

Improve AppHelperNodeStatus to make nodeType attribute available only when the app is installed on the node.

Screenshot

WHY

Currently the code in place can't check the type of the node without having the app installed, and nodeType in AppHelperNodeStatus might lead one to think that it can.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp self-assigned this Nov 21, 2023
@luizgrp luizgrp force-pushed the datalayer_improve_nodetype branch from e0543b2 to 190462b Compare November 21, 2023 14:27
@luizgrp luizgrp mentioned this pull request Nov 21, 2023
Closed
2 tasks
@luizgrp luizgrp requested review from garanj and yschimke November 21, 2023 15:42
@luizgrp luizgrp force-pushed the datalayer_improve_nodetype branch from 190462b to 05df666 Compare November 21, 2023 15:52
yschimke
yschimke approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My brain works the other way, but no strong objection and you've talked it though with Garan. LGTM

Other way being the existing way.

    val isAppInstalled: Boolean,
    val nodeType: AppHelperNodeType,

@garanj
Copy link
Collaborator

garanj commented Nov 22, 2023

This definitely makes it clear, thanks @luizgrp

@luizgrp luizgrp marked this pull request as ready for review November 22, 2023 13:46
@luizgrp luizgrp merged commit 4bbd268 into google:main Nov 22, 2023
@luizgrp luizgrp deleted the datalayer_improve_nodetype branch November 22, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

@garanj garanj garanj approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luizgrp @garanj @yschimke