Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog Screen Size test #1823

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Dialog Screen Size test #1823

merged 8 commits into from
Nov 20, 2023

Conversation

yschimke
Copy link
Collaborator

WHAT

Dialog Screen Size test

WHY

Check responsive layout for dialogs.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke marked this pull request as ready for review November 20, 2023 03:57
@yschimke yschimke requested a review from luizgrp November 20, 2023 04:19
@yschimke
Copy link
Collaborator Author

@luizgrp landing as test only

@yschimke yschimke merged commit 4916dbf into google:main Nov 20, 2023
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Question: are we planning to test components from wear compose in the project?

@yschimke yschimke deleted the dialogs branch December 18, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants