-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update check gradle files #1774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Failing in CI with:
> Task :media:spotlessKotlinGradle FAILED
Step 'ktlint' found problem in 'sample/build.gradle.kts':
Error on line: 283, column: 21
rule: standard:max-line-length
Exceeded max line length (140)
You can check locally running the command described in https://github.com/google/horologist/blob/main/CONTRIBUTING.md#development
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
* Copyright 2023 The Android Open Source Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing all these formatting issues in all the files 👍
In my local it works ok, I am not sure why it falied in CI |
@luizgrp I have manually split the lines that break the rules, could you approve the workflow again and see if the CI check passes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the manual work! We should look why the spotlessApply task is not fixing those.
LGTM, thank you!
I have raised a issue in ktlint, I think the problem is they did not support for breaking long string into two lines. |
WHAT
Fixes #1639
WHY
See description in #1639
HOW
Add Kotlingradle field to spotless check and remove old groovy check
Checklist 📋