Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check gradle files #1774

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Conversation

Ao-senXiong
Copy link
Contributor

WHAT

Fixes #1639

WHY

See description in #1639

HOW

Add Kotlingradle field to spotless check and remove old groovy check

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • [yes] Run spotless check
  • Run tests
  • Update metalava's signature text files

Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Failing in CI with:

> Task :media:spotlessKotlinGradle FAILED
Step 'ktlint' found problem in 'sample/build.gradle.kts':
Error on line: 283, column: 21
rule: standard:max-line-length
Exceeded max line length (140)

You can check locally running the command described in https://github.com/google/horologist/blob/main/CONTRIBUTING.md#development

build.gradle.kts Show resolved Hide resolved
* See the License for the specific language governing permissions and
* limitations under the License.
*/
* Copyright 2023 The Android Open Source Project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing all these formatting issues in all the files 👍

@Ao-senXiong
Copy link
Contributor Author

Thanks!

Failing in CI with:

> Task :media:spotlessKotlinGradle FAILED
Step 'ktlint' found problem in 'sample/build.gradle.kts':
Error on line: 283, column: 21
rule: standard:max-line-length
Exceeded max line length (140)

You can check locally running the command described in https://github.com/google/horologist/blob/main/CONTRIBUTING.md#development

In my local it works ok, I am not sure why it falied in CI

@Ao-senXiong
Copy link
Contributor Author

Thanks!

Failing in CI with:

> Task :media:spotlessKotlinGradle FAILED
Step 'ktlint' found problem in 'sample/build.gradle.kts':
Error on line: 283, column: 21
rule: standard:max-line-length
Exceeded max line length (140)

You can check locally running the command described in https://github.com/google/horologist/blob/main/CONTRIBUTING.md#development

@luizgrp I have manually split the lines that break the rules, could you approve the workflow again and see if the CI check passes?

Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the manual work! We should look why the spotlessApply task is not fixing those.

LGTM, thank you!

@luizgrp luizgrp merged commit d5cd9bf into google:main Oct 27, 2023
@Ao-senXiong
Copy link
Contributor Author

Sorry for the manual work! We should look why the spotlessApply task is not fixing those.

LGTM, thank you!

I have raised a issue in ktlint, I think the problem is they did not support for breaking long string into two lines.
pinterest/ktlint#2334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update copyright check for gradle build files
2 participants