Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update media-ui to use domain module instead of media-data #176

Merged
merged 2 commits into from
May 18, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented May 17, 2022

WHAT

Update media-ui to use domain media module instead of media-data.

HOW

  • Add dependency on media to media-ui and sample modules;
  • Remove dependency on Media3 from media-ui and sample modules;
  • Update implementations of media-data.PlayerRepository to media.PlayerRepository;
  • Update mappers from media-ui from using Media3 models to media module models;
  • Update tests;
  • Remove PlayerRepository and models from media-data;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp merged commit 90e86cf into google:main May 18, 2022
@luizgrp luizgrp deleted the mediaui_usedomain branch May 18, 2022 09:05
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants