Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screenshots with representative sizes #1702

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Add screenshots with representative sizes #1702

merged 7 commits into from
Sep 20, 2023

Conversation

yschimke
Copy link
Collaborator

WHAT

Add screenshots with representative sizes

WHY

Verify screens from small devices all the way up to Mobvoi TicWatch Pro 5 (233dp)

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

yschimke
yschimke commented Sep 20, 2023
View reviewed changes
...google.android.horologist.screensizes_DevicesTest_screenshot[2]_samsunggalaxywatch6large.png Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug, wrong density.

@yschimke yschimke requested a review from luizgrp September 20, 2023 09:39
luizgrp
luizgrp approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

compose-tools/src/main/java/com/google/android/horologist/compose/tools/Device.kt Outdated Show resolved Hide resolved
compose-tools/src/main/java/com/google/android/horologist/compose/tools/Device.kt Outdated Show resolved Hide resolved
sample/src/test/kotlin/com/google/android/horologist/screensizes/AuthSignInTest.kt Outdated Show resolved Hide resolved
sample/src/test/kotlin/com/google/android/horologist/screensizes/ScreenSizeTest.kt Show resolved Hide resolved
sample/src/test/kotlin/com/google/android/horologist/screensizes/ScreenSizeTest.kt Show resolved Hide resolved
@yschimke yschimke merged commit f329439 into google:main Sep 20, 2023
@yschimke yschimke deleted the screen_sizes branch November 13, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @luizgrp