Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Media module #169

Merged
merged 1 commit into from
May 16, 2022
Merged

Add Media module #169

merged 1 commit into from
May 16, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented May 16, 2022

WHAT

Add module for Media domain library.

WHY

In order to include domain code related to media and publish them as an individual library.

HOW

  • Add a new java/kotlin module;
  • Add maven publish plugin configuration to the module;
  • Add annotation ExperimentalHorologistMediaApi;
  • Add metalava generated API file;

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

yschimke
yschimke reviewed May 16, 2022
View reviewed changes
build.gradle
@@ -39,10 +39,12 @@ buildscript {
}

plugins {

id "com.diffplug.spotless" version "5.9.0"
id 'org.jetbrains.kotlin.android' version '1.6.20' apply false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump these to 1.6.21.

In future use alias also #170

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raised #171 for bumping the kotlin gradle plugin version

@luizgrp luizgrp merged commit 5fbeb43 into google:main May 16, 2022
@luizgrp luizgrp deleted the media_module branch May 16, 2022 09:54
@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke