Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Galaxy Watch Classic detection for haptics #1684

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

Dubzer
Copy link
Contributor

@Dubzer Dubzer commented Sep 17, 2023

WHAT

Improvement to the regex used to detect the Samsung Galaxy Watch model with a bezel.

WHY

Because the previous regex missed 4 Classic 42mm and the newer 6 Classic models.

HOW

Match all Classic model numbers specified in:
https://en.wikipedia.org/wiki/Samsung_Galaxy_Watch_4
https://en.wikipedia.org/wiki/Samsung_Galaxy_Watch_6

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@google-cla
Copy link

google-cla bot commented Sep 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yschimke
Copy link
Collaborator

It would be good to make this method visible for testing (internal?) and have a unit test listing devices, but doesn't need to be in your PR.

@yschimke yschimke merged commit 83d4083 into google:main Sep 18, 2023
@Thomas-Vos
Copy link

Could this be backported to the release-0.4.x branch, please?

@yschimke
Copy link
Collaborator

yschimke commented Oct 2, 2023

I'll take a look

@yschimke
Copy link
Collaborator

yschimke commented Oct 5, 2023

PR here #1742, can release tomorrow if it lands.

@yschimke
Copy link
Collaborator

yschimke commented Oct 6, 2023

0.4.14 is released, should show up in a couple of hours. Let me know if there are any issues, I haven't tested on device, but on emulator it's working ok for scrolling, rsb, position indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants